roboflow / roboflow-python

The official Roboflow Python package. Manage your datasets, models, and deployments. Roboflow has everything you need to build a computer vision application.

https://docs.roboflow.com/python

Apache License 2.0

311 stars 77 forks source link

Maintains compatibility with CLI return, broken in PR #266 #309

Closed lrosemberg closed 2 months ago

lrosemberg commented 2 months ago

Description

In PR #266 the raised errors changed how the CLI response is sent.

Said that, what this PR does?

Create a new custom exceptions to handle correctly in CLI dataset upload
Fix the bug introduced in @266 that fails to parse some image upload responses (more info here: https://github.com/roboflow/roboflow-python/pull/266#issuecomment-2295388263)
Isolates the error handling to _log_img_upload_err that earlier is shared with _log_img_upload
Create some test cases to validate the project.upload

Type of change

[x] Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Created some tests in the code to validate the project.upload bugfix
Downloaded a dataset, edited a annotation to fail, and uploaded using the CLI, results below:

CleanShot 2024-08-18 at 20 09 00@2x

CleanShot 2024-08-18 at 20 12 02@2x