Remove cursor pointer on hover

[ediardo]

The cursor pointer is misleading because it makes the element seem clickable, like a button or link. However, when I click it, nothing happens, which is frustrating. Thank you.

Description

• Remove the cursor property from the .repo-card class.

List any dependencies that are required for this change.

Type of change

Please delete options that are not relevant.

• [x] Bug fix (non-breaking change which fixes an issue)

How has this change been tested, please provide a testcase or example of how you tested the change?

Tested it with poetry run pytest.

[CLAassistant]

All committers have signed the CLA.

[onuralpszr]

Hello, @ediardo is it still draft or may I start to check ?

[ediardo]

Hello, @ediardo is it still draft or may I start to check ?

Hi! The change is small and easy to test live on the browser, but I couldn't build and test the changes locally.

The change is pretty small and probably harmless.

Errors:

$ mkdocs build
Error: MkDocs encountered an error parsing the configuration file: while constructing a Python object
cannot find module 'material.extensions.emoji' (No module named 'material')
  in "/Users/ediardo/git/supervision/mkdocs.yml", line 171, column 20

$ mkdocs serve
Error: MkDocs encountered an error parsing the configuration file: while constructing a Python object
cannot find module 'material.extensions.emoji' (No module named 'material')
  in "/Users/ediardo/git/supervision/mkdocs.yml", line 171, column 20

$ pip install mkdocs-material
Collecting mkdocs-material
  Using cached mkdocs_material-9.5.31-py3-none-any.whl.metadata (17 kB)
Requirement already satisfied: babel~=2.10 in /opt/anaconda3/lib/python3.11/site-packages (from mkdocs-material) (2.11.0)
Requirement already satisfied: colorama~=0.4 in /opt/anaconda3/lib/python3.11/site-packages (from mkdocs-material) (0.4.4)
Requirement already satisfied: jinja2~=3.0 in /opt/anaconda3/lib/python3.11/site-packages (from mkdocs-material) (3.1.4)
Requirement already satisfied: markdown~=3.2 in /opt/anaconda3/lib/python3.11/site-packages (from mkdocs-material) (3.4.1)
Collecting mkdocs-material-extensions~=1.3 (from mkdocs-material)
  Using cached mkdocs_material_extensions-1.3.1-py3-none-any.whl.metadata (6.9 kB)
Requirement already satisfied: mkdocs~=1.6 in /opt/anaconda3/lib/python3.11/site-packages (from mkdocs-material) (1.6.0)
Collecting paginate~=0.5 (from mkdocs-material)
  Using cached paginate-0.5.6.tar.gz (12 kB)
  Preparing metadata (setup.py) ... error
  error: subprocess-exited-with-error

  × python setup.py egg_info did not run successfully.
  │ exit code: 1
  ╰─> [1 lines of output]
      ERROR: Can not execute `setup.py` since setuptools is not available in the build environment.
      [end of output]

  note: This error originates from a subprocess, and is likely not a problem with pip.
error: metadata-generation-failed

× Encountered error while generating package metadata.
╰─> See above for output.

note: This is an issue with the package mentioned above, not pip.
hint: See above for details.

$ pip install setuptools
Requirement already satisfied: setuptools in /opt/anaconda3/lib/python3.11/site-packages (72.2.0)

[LinasKo]

Hi @ediardo 👋

I've tested it; it works as described it. The background of these cards, which formerly showed a pointer but was not clickable, now no longer shows a pointer.

Here's some unusual logic: seeing it as a pointer hints it to the user that it ought to be clickable. And if it doesn't work, they will try clicking on the title.

Maybe we should keep it until we find a way to make cards clicklable?

@onuralpszr, what do you think?

[onuralpszr]

Hi @ediardo 👋

I've tested it; it works as described it. The background of these cards, which formerly showed a pointer but was not clickable, now no longer shows a pointer.

Here's some unusual logic: seeing it as a pointer hints it to the user that it ought to be clickable. And if it doesn't work, they will try clicking on the title.

Maybe we should keep it until we find a way to make cards clicklable?

@onuralpszr, what do you think?

I was actually doing that right now also improve "docs install" part I will add bit more extra

card + title clickable also works for me as well.

[onuralpszr]

@LinasKo I did it, do you want me to transform THIS PR to new stuff I did or open new PR ?

[LinasKo]

@onuralpszr,

Let's make a new one. Thanks!

[onuralpszr]

Superseded via #1459

[LinasKo]

While we're not merging this PR, it revealed a slightly better solution. Thank you for your contribution, @ediardo! Without it, we may not have touched the cookbook cards at all.

[ediardo]

It's awesome to see others interested in improving this part of the documents. Thank you!