robofont-mechanic / Mechanic

Package manager for RoboFont extensions
http://robofontmechanic.com
MIT License
26 stars 7 forks source link

expatError #18

Closed typemytype closed 8 years ago

typemytype commented 8 years ago
******************************
Traceback (most recent call last):
  File "/Users/frederik/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/threaded.py", line 62, in run_
  File "/Users/frederik/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/ui/tabs/updates.py", line 64, in update_list
  File "/Users/frederik/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/ui/lists/update.py", line 40, in refresh
  File "/Users/frederik/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/update.py", line 25, in all
  File "/Users/frederik/Library/Application Support/RoboFont/plugins/Mechanic.roboFontExt/lib/mechanic/update.py", line 39, in _fetch_updates
ExpatError: not well-formed (invalid token): line 34, column 0

******************************
typemytype commented 8 years ago

There was an extension that has a malformed info.plist file (an extension Im working on)

This should not happen but it could be possible that one of the installed extension is not valid... maybe Mechanic should skip those?

An ExentsionBundle has a validate() callback that you can use

jackjennings commented 8 years ago

I had a hunch that this was the issue, and I was looking into how to except from this. Python errors are kind of frustrating to work on when the error originates from a library, but I think that I have a solution that I can release later today.

Which extension had the plist in question?

typemytype commented 8 years ago

solved here

https://github.com/typemytype/RoboFontExtensions/commit/8ebb8da3bcb9e17da62c179bfa0d4b8bc4808241

dont understand where those > went...

jackjennings commented 8 years ago

Hey @typemytype, I added an exception that fixes this case, and a warning (which will be logged when I get that running again).

typemytype commented 8 years ago

thanks