CSV import for newsletters doesn't work unless type column explicitly specified

robogals / myrobogals

myRobogals is the global intranet and record-keeping tool for Robogals. It has been built to simplify many of our day-to-day tasks including organising school visits, maintaining a member database, communicating with members, storing records reliably for future generations and easily collecting statistics on a global scale.

https://my.robogals.org

10 stars 21 forks source link

CSV import for newsletters doesn't work unless type column explicitly specified #5

Closed U-238 closed 11 years ago

U-238 commented 12 years ago

Need to make it work where the type is not specified and the default isn't specified either. In which case the type should simply be NULL.

U-238 commented 11 years ago

I'm not sure whether this is still an issue. Could someone please see whether it is? The steps to reproduce are:

Go to Email & SMS > Newsletter CP
Upload a CSV file that is missing the "type" column but is otherwise valid
Do not select a default value for type

The correct behaviour would be for the type field to be left blank on each of the imported subscribers. But I think it might just crash instead.

manhinli commented 11 years ago

Does not appear to be an issue after a quick test with a single column CSV with emails.

Closing.