search

robojumper / DarkestDungeonSaveEditor

Darkest Dungeon Save File (.json) Reader, Writer, Editor. Also, Spreadsheets.
MIT License
74 stars 8 forks source link

Error reading: Wrong string hash persist.roster #13

Closed DarkestMan1 closed 5 years ago

DarkestMan1 commented 5 years ago

I attempted to use this on my heavily modded save (with custom characters, character limit extenders, and new trinkets/ trinket slot extenders) and this happened. What seems to be the matter?

persist.roster.zip

robojumper commented 5 years ago

https://github.com/robojumper/DarkestDungeonSaveEditor/blob/50c28e9058a18896235fa9c1bc310f70c64a2652/src/main/java/de/robojumper/ddsavereader/file/DsonFile.java#L116-L118

This file contains a field with a name that mismatches the hash specified in the save file header. The decoder rejects the file in order to minimize potential errors from parsing data the wrong way.

There is a chance that I'm getting the string encoding wrong. I'll look into 1) finding the erroneous field and fixing the error if it's on my side and 2) making the error message more useful.

DarkestMan1 commented 5 years ago

Oh, that makes sense. Alright, thank you for responding so quick man! You're awesome!

robojumper commented 5 years ago

14 fixes this. This is in fact an error on my side, where I implicitly assumed that field names were ASCII. However, the Conquerer mod (which I assume you're using) contains skills like stärke, which the decoder (and encoder) couldn't handle.

The fix is up, but I'll think it over and cut a release in the next few days.

DarkestMan1 commented 5 years ago

Thanks man! Yeah I am using it. That's interesting to know that that's the reason why things went kaput.