robojumper / DarkestDungeonSaveEditor

Darkest Dungeon Save File (.json) Reader, Writer, Editor. Also, Spreadsheets.
MIT License
74 stars 8 forks source link

Fix GUI latency #20

Closed robojumper closed 4 years ago

robojumper commented 4 years ago

Right now, every keypress directly causes the files to be re-encoded to check whether they are OK and show errors. For small files this is acceptable, for large files, this

melts the save editor

(As in, causes a lot of latency.) The work needs to be offloaded to a background task and the GUI needs to be audited for errors so that we don't allow saving while currently figuring out that the file is invalid and so on.

TODO: How bad is it for the browser version?