Friending

[gorterd]

Awesome work!

• Styling:
  • [x] I'd recommend adding more padding for the grey background above and below the text here:
  • [x] In terms of layout, when the screen gets fairly wide, there's a gap between the right edge of the dashboard and the Friend Settings. In addition, when the screen gets fairly tall, the dashboard ends mid screen (you probably don't want a hardcoded height, but instead use units like vh in combination with calc()). Compare with splitwise below.
• After removing a friend, the url stays on that friend's show page. I'd recommend it redirect to the main dashboard.
• I remember your plan yesterday was to include email addresses of existing users in your production README for easy friending. Some thoughts:
  • I think that's a good idea; however, one thing to consider is that some recruiters might go straight to your website, skipping the README.
  • You also mentioned you could remove a friend a re-add; for that to work, somewhere on a user's profile their email address should be displayed.
  • One idea that would be simpler than a suggestion box: have a link right below the input that would lead to the section of the README where you have a list of available users' email addresses. You can actually link to headings within a README on GitHub. (Example)
  • More complex idea: fetch a list of all users while fetching the friend list. Then, have placeholder text suggesting one of the users that isn't currently a friend. E.g.: Try: other_user@demo.com.
  • I'm curious: where are the seeded users coming from? I don't see them in your db/seed.rb on GitHub.

[robokitten007]

• fixed padding and element height
• will implement the recommendations at readme and cleanup phase
• regarding seed.rb it probably wasn't updated on github when you checked it earlier. i just pushed the whole branch it should be there now.