search

roboll / helmfile

Deploy Kubernetes Helm Charts
MIT License
4.04k stars 566 forks source link

Global hooks not running with nested sub-helmfiles #1997

Open igorkatz opened 2 years ago

igorkatz commented 2 years ago

Hi, My helmfile version: helmfile version v0.139.9

snippet of my helmfile.yaml:

---
repositories:
  - ...

helmDefaults:
  timeout: 600
  atomic: true
  cleanupOnFail: true
  skipDeps: true

hooks:
- events: ["prepare"]
  showlogs: true
  command: "/bin/sh"
  args: ["-c", "kubectl apply -f predefined-env.yaml --namespace mi-paas"]

helmfiles:
  - groups/*.yaml

helmfile command is used: helmfile --debug --no-color apply --skip-diff-on-install --skip-deps

Problem: Global hooks do not work when nested asub-helmfiles are defined If remove nested sub-helmfiles, global hooks will run:

helmfiles:
#  - groups/*.yaml
tonygilkerson commented 2 years ago

I am having the same problem. It was working about a month or two ago but not now. Given the age of this issue perhaps it was fixed then reintroduced?