roboll / helmfile

Deploy Kubernetes Helm Charts
MIT License
4.04k stars 566 forks source link

arm64 docker image #2014

Open morganchristiansson opened 2 years ago

morganchristiansson commented 2 years ago

The docker images on https://quay.io/repository/roboll/helmfile do not support multi-arch / arm64.

I realize you offer arm64 binaries already and I can build arm64 myself but would be nice if official image had arm64. I can have a go at updating circleci in a PR?

morganchristiansson commented 2 years ago

Building docker image on arm64 currently fails on installing helm-diff plugin.

docker buildx build \
        --platform=linux/amd64,linux/arm64 \
        -t quay.io/work/helmfile:v0.142.0 \
        .
 > [linux/arm64 stage-1 6/7] RUN helm plugin install https://github.com/databus23/helm-diff --version v3.1.3 &&     helm plugin install https://github.com/jkroepke/helm-secrets --version v3.5.0 &&     helm plugin install https://github.com/hypnoglow/helm-s3.git --version v0.10.0 &&     helm plugin install https://github.com/aslafy-z/helm-git.git --version v0.10.0:                                            
#14 7.272 No prebuild binary for linux-arm64.                                                                                                                                                                
#14 7.276 Failed to install helm-diff                                                                                                                                                                        
#14 7.278       For support, go to https://github.com/databus23/helm-diff.                                                                                                                                   
#14 7.280 Error: plugin install hook for "diff" exited with error                                                                                                                                            
------                                                                                                                                                                                                       
Dockerfile:49                                                                                                                                                                                                
--------------------                                                                                                                                                                                         
  48 |                                                                                                                                                                                                       
  49 | >>> RUN helm plugin install https://github.com/databus23/helm-diff --version v3.1.3 && \                                                                                                              

Lack of arm64 has been reported in several issues in helm-diff repo https://github.com/databus23/helm-diff/issues?q=arm64

morganchristiansson commented 2 years ago

helm-diff has released 3.2.0 with arm64 support https://github.com/databus23/helm-diff/releases/tag/v3.2.0

morganchristiansson commented 2 years ago

Had a go at updating build scripts in PR #2040

AlKapkone commented 2 years ago

+1 for arm64 image