search

roboll / helmfile

Deploy Kubernetes Helm Charts
MIT License
4.05k stars 565 forks source link

Handle SIGTERM for dependent helm processes #2160

Open jonnylangefeld opened 2 years ago

jonnylangefeld commented 2 years ago

helm handles SIGTERM gracefully. helmfile captures SIGTERM, but does nothing to pass the SIGTERM on to the helm processes to roll back those charts. This is often painful in CI when many charts get stuck due to a SIGTERM and an immediate shutdown of the agent, once the helmfile process exited. At this time the helm processes might still be working and get killed by the agent, which leaves the chart in the "pending-install" state, from which one can only manually recover.

helmfile should pass the SIGTERM to the child processes and only exit once all child processes exited.

yxxhero commented 2 years ago

@jonnylangefeld please use v0.148.1

yxxhero commented 2 years ago

https://github.com/helmfile/helmfile