search

roboll / helmfile

Deploy Kubernetes Helm Charts
MIT License
4.05k stars 566 forks source link

`--interactive` have no effect with `charts` and `sync` commands #416

Open victornoel opened 5 years ago

victornoel commented 5 years ago

I'm not exactly sure if this is on purpose, but the --interactive parameter is globally scoped (so it's a general helmfile parameter and not an apply parameter) and thus I would expect it to be honoured whatever the command is run.

mumoshu commented 5 years ago

@victornoel Good point!

--interactive has effects only on apply and delete. We should make it non-global.

andrewnazarov commented 5 years ago

My two cents. Regarding helmfile delete I would like to have functionality introduced by -i as default behavior. Some sort of --non-interactive flag makes more sense to me in that case. As I don't want my releases to be destroyed accidentally by somebody else having access to the cluster. So, pretty much the same as terraform destroy and its -auto-approve flag.

I'm not talking about reconsidering the approach right now, just sharing some thoughts on it.

manics commented 5 years ago

There was a long discussion on whether interactive or non-interactive should be the default here 😀: https://github.com/roboll/helmfile/issues/354

One reason --interactive was made a top-level argument was to support aliasing of helmfile to whatever behaviour people preferred https://github.com/roboll/helmfile/issues/354#issuecomment-424028564

andrewnazarov commented 5 years ago

Ah, I see. That's kinda funny). Thank you for pointing it out.