search

roboll / helmfile

Deploy Kubernetes Helm Charts
MIT License
4.05k stars 564 forks source link

hard dependency on helm diff plugin #846

Open red8888 opened 5 years ago

red8888 commented 5 years ago

docs dont say this but looks like I need to install the helm diff plugin to use helmfile?

when I run helmfile apply it throws an error saying it cant find helm diff

Im new to this so maybe stupid question- could helm diff be included in the helmfile install? or maybe embed helm diff into helmfile? My toolchain seems to be growing exponentially with all these little tools. It just makes me reluctant to go to production with a stack like this.

terrancej commented 4 years ago

I also ran into this as well and errors didn't help, error checking for whether the plugin is installed would be nice

joshes commented 4 years ago

I just ran into this myself. Not sure the correct way to handle this one; via a documentation update or something else...? I'd be happy to send an PR but would like some direction towards what the right fix is.

The following will get a default setup up and running from the "Getting Started" section of the docs:

$ brew install helm helmfiles
$ helm repo add stable https://kubernetes-charts.storage.googleapis.com
$ helm plugin install https://github.com/databus23/helm-diff --version master
$ cat helmfile.yaml
releases:
- name: prom-norbac-ubuntu
  namespace: prometheus
  chart: stable/prometheus
  set:
  - name: rbac.create
    value: false

$ kubectl create namespace prometheus
$ helmfile apply