search

robopeak / rplidar_ros

BSD 2-Clause "Simplified" License
453 stars 370 forks source link

Repo description and link to ROS wiki page #28

Closed bit-pirate closed 7 years ago

bit-pirate commented 8 years ago

Suggesting to add this to this GitHub repo. See our fork for reference: https://github.com/yujinrobot/rplidar_ros

This help ROS users to jump back and forth between the doc (ROS wiki) and code (GitHub repo).

PS: I just created an empty page on the ROS wiki for this package: http://wiki.ros.org/rplidar_ros

kintzhao commented 8 years ago 
 Thanks for your improvement using nodelet,  we will review and evaluate your repo. you should notice that we have  upgrade the SDK  to 1.5.4  for rplidar A1/A2.
bit-pirate commented 8 years ago

Hi @kintzhao. This issue is just about adding a description for this repo and a link to a website, e.g. the ROS wiki. I have edited our fork as example:

rplidar_repo_description_website

Regarding the code changes in our repo, we will open separate PRs for the new features, such as the nodelet.

kintzhao commented 7 years ago

I notice that your node about rplidar_ros with nodelet has been deleted.