robopeak / rplidar_ros

BSD 2-Clause "Simplified" License
453 stars 370 forks source link

fix timeout in initialization #43

Open SGSSGene opened 7 years ago

SGSSGene commented 7 years ago

This PR is supposed to fix the timeout parameter in the raw_serial::waitfordata function.

The Issue turns up when for example the call ptr->waitfordata(2, 1000, 0) is being made. Now for some reason the serial device only sends one byte instead of two. This will cause the later call int n = ::select(max_fd, &input_set, NULL, NULL, &timeout_val); to never flag "TIMEOUT", it will always signal that the fd is ready to be read. This causes the whole system to hang at this point and never return.

My fix forces to break out of the loop if the TIMEOUT is being reached.