search

roborourke / wp-less

Provides a LESS compiler compatible with wp_enqueue_style() for rapid CSS development in themes and plugins.
MIT License
217 stars 56 forks source link

Implement WP_Filesystem API for writing/reading files #27

Open roborourke opened 11 years ago

roborourke commented 11 years ago

This is aiming to make the plugin more embeddable in themes, it will have to use the filesystem API if it's to be able to pass the theme checker for hosting on wp.org. Also it makes for better security.

Of course it also depends on lessphp itself so may be a no go.

willmot commented 11 years ago

The problem with WP_Filesystem for something like generating the cache files is it will only work if direct writing is possible as FTP/SFTP/FTPS details aren't stored and you probably can't prompt for them every time the cache file needs writing.

This is made worse by the fact that WP_Filesystem only allows direct writing in specific circumstances, even though php does have is_writable access.

Thats the reason I'm not using it in BackUpWordPress for writing the backup files.

You could obviously work round it by prompting people to define their FTP/SFTP/FTPS details in wp-config.php.

roborourke commented 11 years ago

Cheers Tom, I realised this is a total no go as the lessc class uses file_put_contents etc... Best keep this is a plugin and go the theme dependency route.

franz-josef-kaiser commented 11 years ago

Maybe we should update the README with this info...

roborourke commented 11 years ago

I'm reopening this one for discussion as I want to try using the WP_Filesystem_Direct class (extends WP_Filesystem_Base).

It would be easy enough to test if it works at which point we could use that to take advantage of the automatic chmod'ing it does for security reasons.

One other reason for reconsidering is folks using origin-push CDN setups. Although for that particular case the best bet would be to add a post-compile action hook with the URLs and paths etc...

Rarst commented 11 years ago

I don't see much benefit other than chmod (which is to-be-really-sure kind of a thing in this context), however no downside either. To be fancy can try to write properly with filesystem and fall back to direct instead of asking credentials.

The small issue is overriding filesystem write(s) (there seems to be total of one, but I hadn't looked hard) in lessc, but can subclass it for that.

bearded-avenger commented 10 years ago

I'm using this class in a theme, tied to the theme customization API to provide real time color automation. I'm at the end of it and bug checking before submitting to repo, and Theme Check is of course flagging the file_put_contents.

If there's any way we can utilize WP Filesystem API that would be rad.

roborourke commented 10 years ago

Hi Nick, I did look into it some time ago but the only use case so far is to get a theme accepted by the wp.org repo which most users of the plugin don't do (much). It might be possible to get them to make an exception in this case, the problems raised by Tom and Rarst are quite significant barriers to this approach and it's fundamental to the functioning of the plugin.

You could ask on the theme reviewers mailing list if it's ok http://lists.wordpress.org/mailman/listinfo/theme-reviewers

They make exceptions for the likes of pagelines so it's not outside the realms of possibility.

bearded-avenger commented 10 years ago

Fair enough, and totally understandable. Thanks man, appreciate the response.