search

roboscala / sbt-robovm

An sbt plugin for iOS development in Scala
BSD 2-Clause "Simplified" License
108 stars 16 forks source link

Support for RoboVM 1.5.0 #34

Closed zikolach closed 9 years ago

Darkyenus commented 9 years ago

Whoa. Just a note that this doesn't just update to 1.5.0, it also does a quite lot of (breaking) changes.

zikolach commented 9 years ago

Yes, and there is an issue in examples with NoClassDefFound for StdIn. Would be nice to fix it, because 1.0.0-alpha seems a bit outdated :(

On Mon, Jul 20, 2015, 23:09 Jan Polák notifications@github.com wrote:

Whoa. Just a note that this doesn't just update to 1.5.0, it also does a quite lot of (breaking) changes.

— Reply to this email directly or view it on GitHub https://github.com/roboscala/sbt-robovm/pull/34#issuecomment-123040022.

Darkyenus commented 9 years ago

Where is the issue, here or in my fork? (I have also forked the examples)

zikolach commented 9 years ago

I just forked both your repos - sbt robovm plugin and examples. When I updated versions I noticed a bug in native example. I didn't check what caused issue with StdIn yet.

Darkyenus commented 9 years ago

Please report any bugs you find to the respective repo, I'll try to fix them.

pocorall commented 9 years ago

@ajhager seems very busy so that he cannot review this awesome pull request. Definately, this should be merged to mainstream.

Darkyenus commented 9 years ago

Wow, I didn't think that this would get merged. In this case, there will have to be a few changes, mainly (and maybe only) in README, since I have put some my-fork-specific info there. I think I can provide PR for that after the weekend. In any case, are you planning to publish to plugin repo?

pocorall commented 9 years ago

I don't have a permission to access the plugin repo. Some days ago, I just requested to @ajhager for becoming a committer of this git repo.

Darkyenus commented 9 years ago

Oh, okay then

ajhager commented 9 years ago

My apologies, I have been in the process of changing jobs (RoboVM actually!), getting married, and have just moved across the country. Thanks @Darkyenus for the PR and @pocorall for handling the merge. I agree we need a better protocol for doing plugin releases, and I want to make sure that I am not the weak link for updates and releases. I have broken this discussion off to #35, so feel free to respond.

pocorall commented 9 years ago

Congratulations! you got a great job. More congratulations on your marriage!