search

roboshoes / grunt-json-bake

Grunt plugin that lets you merge multiple JSON files into one.
MIT License
7 stars 3 forks source link

Added variables support #4

Closed liorcode closed 10 years ago

liorcode commented 10 years ago

I added variables support in the json file. This is useful to easily load different files based on a variable name, such as "environment". See the read me for an example.

roboshoes commented 10 years ago

Thanks for the PR. Let me review this tonight and get back to you.

roboshoes commented 10 years ago

Hey there, sorry for the delay and thanks for the PR. I like your addition but I changed a few things here and there. I think I could reduce it a little with a simple String.replace.

If you are ok with it I would add your info to the package.json. Do you have name and email/url you want me to add?

liorcode commented 10 years ago

Thanks, I like your simplifications. You can add Lior Chen / liorchen at gmail com but I don't need the credit

roboshoes commented 10 years ago

You know, credit where credit is due.