simple state machine with an action client and a topic subscriber

[sukhrajklair]

• state machine has two states
• one state transitions to another state based on the data received on a topic
• one of the states contains an action client which sends a goal to /fibonacci action server. The implementation of action server is provided as part of ROS2 tutorials.

┆Issue is synchronized with this Jira Task by Unito

[brettpac]

Hi Sukhraj, I had a look to the build, and I have two requests...

1. Can we add the standard apache2 license for these files... smacc2_sm_reference_library/simple_action_client_example/include/simple_action_client_example/mode_selection_client/cl_mode_select.hpp: could not find copyright notice smacc2_sm_reference_library/simple_action_client_example/include/simple_action_client_example/orthogonals/or_mode_select.hpp: could not find copyright notice 2 errors, checked 377 files smacc2_sm_reference_library/simple_action_client_example/include/simple_action_client_example/orthogonals/or_fibonacci.hpp: could not find copyright notice 1 errors, checked 341 files smacc2_sm_reference_library/simple_action_client_example/include/simple_action_client_example/mode_selection_client/client_behaviors/cb_mode_select.hpp: could not find copyright notice

2. And can you rename the state machine to sm_simple_action_client (for files) /SmSimpleActionClient (for class) to keep with the naming convention of the reference library please?

I'm tempted to just squash the PR and just do it myself, but I'm trying to follow the CI process here;)

Thank you, I really appreciate it. I'm excited to get this PR merged.

[brettpac]

// Copyright 2021 RobosoftAI Inc. // // Licensed under the Apache License, Version 2.0 (the "License"); // you may not use this file except in compliance with the License. // You may obtain a copy of the License at // // http://www.apache.org/licenses/LICENSE-2.0 // // Unless required by applicable law or agreed to in writing, software // distributed under the License is distributed on an "AS IS" BASIS, // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. // See the License for the specific language governing permissions and // limitations under the License.

/***** *

• Author: Sukhraj Klair

• **/

[brettpac]

Hi @sukhrajklair, lets try running the pre-commit run -a command on your local machine please and then pushing. I think it will pass the format check after that.

[sukhrajklair]

Hi @brettpac Looks like all of the formatting errors are fixed