search

robot256 / cargo_ships

factorio mod that adds cargo ships and other content to the game
5 stars 10 forks source link

Nullius Compatibility #14

Closed Ratainen closed 1 year ago

Ratainen commented 1 year ago

Changes the recipes and technologies to work with Nullius if that's installed. The science and recipe prices should be some what relatively close, with the vanilla versions, atleast I tried to make them some what close. Though many things that required iron, I replaced with steel, because Nullius recipes seem to have that, for example the locomotive requires steel gears and cargo wagon all steel parts, except the lubricant. The oil platform just get's disabled, it could be changed to a volcanic gas platform, because that's basically Nullius oil, but I have no idea how to do that, as I don't understand the oil generation code at all so that just gets disabled. Also there's probably better way to fix the pump collision thingy crash, but it works now. Also the reason why there's 2 commits, is because I though that I needed to do the git add only for the new files, but you needed to do it for the changed ones too. (edit after 3h) there was a crash when you tried to blueprint something, so I just added a check for nil in there, so it doesn't crash, so there's the third commit.

Ratainen commented 1 year ago

Ok, I did the chances now.

robot256 commented 1 year ago

Thanks!

robot256 commented 11 months ago

@Ratainen I want to let you know we need to remove this patch from Cargo Ships after all. There are competing visions for what Nullius compatibility would look like, so we don't want to put a specific one in Cargo Ships proper. I encourage you to make a helper mod that changes the recipes the way you want, with Cargo Ships as a dependency. You can also make your helper mod force-disable the Offshore Oil setting, I help you with the code if you like.

Ratainen commented 11 months ago

@robot256 Ok, but I feel like that would be kinda useless, because tburrows just did it better, with the offshore oil compatibility. Also im just wondering why was the blueprint crash fix reverted too?

robot256 commented 11 months ago

Also im just wondering why was the blueprint crash fix reverted too?

That was probably an oversight, I'll check on it. Thanks for the reminder!

tburrows13 commented 11 months ago

The blueprint crash fix was reimplemented in #20. I reverted it from here because I wasn’t sure I could revert older commits before newer ones. And I fancied doing it slightly differently.

tburrows13 commented 11 months ago

Ok, but I feel like that would be kinda useless, because tburrows just did it better, with the offshore oil compatibility.

To be clear, it wasn’t me that did the Cargo Ships + Nullius compat, it is the author of Nullius :) but yes, I agree there’s little point doing compat in your own mod, you’ll just have to wait for the next version of Nullius.