search

robota-suite / robota-core

A Python package for reading in elements of GitLab and GitHub repositories, for further analysis.
https://robota-core.readthedocs.io
MIT License
0 stars 8 forks source link

Create CI pipeline for this repo #11

Closed lourencofsilva closed 1 month ago

lourencofsilva commented 1 month ago

Taking into account the potential for further pull requests, a CI pipeline should be added to ensure automated testing.

suzanneEmbury commented 1 month ago

This will be super helpful, @lourencofsilva , I agree. I look forward to seeing the PR for this!

lourencofsilva commented 1 month ago

@suzanneEmbury please see PR above for this. Regarding automated PyPI releases, I see that these are currently being published from the GitLab repo using tags and not GitHub, so it wouldn't make sense to create an action here, correct?

suzanneEmbury commented 1 month ago

Thanks for your hard work on this @lourencofsilva . I'm working on the next code review but am a bit busy with marking and other projects, so my responses (as you've seen) will be a bit delayed. But I am still working on this and will get back to you as soon as I can.

Regarding your point about deployment from GitLab, you're correct - but we may choose to either keep this repo as a mirror of the GitLab one, and deploy from here - or even, if it gets more active, move to using this repo as the main repo for work on this code base.

But it's fine to leave this for now. We have enough to be getting on with before we worry about automated upload to PyPI.

lourencofsilva commented 1 month ago

No worries at all. I've also been quite busy with exams! That makes sense, will leave as is for now.