robotastic / trunk-recorder

Records calls from a Trunked Radio System (P25 & SmartNet)
GNU General Public License v3.0
848 stars 191 forks source link

Add title tag to m4a files? #369

Open dmonies327 opened 4 years ago

dmonies327 commented 4 years ago

Is it possible to add a title tag to the m4a files created when uploading to openMHZ/broadcastify calls? I'd like to use these files with liquidsoap to stream to broadcastify as they are already balanced/normalized well, and there's no need to repackage the wav to mp3 just to add title comments if liquidsoap can play/stream the m4a/aac files (assuming this can also be done). I'd like them to have the TITLE tag on them, however. If this isn't practical, does anyone know a good utility to quickly add the tag to the file that could be run in a separate script (similar to the way the encode_upload.sh does in the TR/LiquidSoap wiki writeup on RR)? I tried using id3v2 to add it, but it appears to just corrupt the files. EDIT: I believe I found that I should be using mutagen to do this, but the original question still stands as to if trunk-recorder already has this functionality.

EricTendian commented 4 years ago

There isn't that functionality currently available within trunk-recorder itself, since in https://github.com/robotastic/trunk-recorder/blob/master/trunk-recorder/uploaders/call_uploader.cc#L20 we are just converting the wav to a m4a. However, it looks like fdkaac does have an argument --title so it probably would be possible to modify the upload logic to include whatever alpha tag is associated with the talkgroup if it exists.

robotastic commented 4 years ago

This is a good idea and should be a pretty easy change. I will add this to my list of things.

natecarlson commented 3 years ago

What content do you want in the tag?

Or in the ideal world should it be configurable, with placeholders for each of the major variables?

(It'd be absolutely trivial to hard code it to something; making it configurable would be a bit more work - at least for someone like me who can write C but kinda sucks at it.)

dmonies327 commented 3 years ago

The alpha-tag associated with the talk group would be ideal, but configurable might be more flexible for the community.

On Thu, Nov 26, 2020, 00:20 Nate Carlson notifications@github.com wrote:

What content do you want in the tag?

Or in the ideal world should it be configurable, with placeholders for each of the major variables?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/robotastic/trunk-recorder/issues/369#issuecomment-734099268, or unsubscribe https://github.com/notifications/unsubscribe-auth/ACE7OI7BGXWQMV2VMH6TE23SRXXTZANCNFSM4NZKJVAA .