search

robotastic / trunk-recorder

Records calls from a Trunked Radio System (P25 & SmartNet)
GNU General Public License v3.0
876 stars 196 forks source link

Making UHD, USRP requirements optional #665

Open rosecitytransit opened 2 years ago

rosecitytransit commented 2 years ago

Attached is a patch that removes the UHD/USRP code sections from the current master branch in order to be able to compile without having support for those more expensive SDRs.

If there's a desire and it's easily to do, I was wondering if those sections could be made optional.

0001-compiles-w-o-UHD-USRP-support.patch.txt

robotastic commented 2 years ago

It is pretty hard for me to track the changes with a Patch - can you submit it as PR?

The UHD/USRP is being used so, it would need to be included by default. There could be something with a CMAKE flag to optional disable it.... but so far I haven't done CMAKE flags and it creates additional scenarios to test against.

Can you explain more about why you are interested in this?

rosecitytransit commented 2 years ago

I haven't actually investigated how to set things up to do it. I definitely agree that by default UHD/USRP should be supported; I was thinking of something like "if (UHD libraries exist) then include UHD code".

Since I had no plans to use anything besides RTL devices, I installed GNU Radio without support for other types (using https://github.com/robotastic/trunk-recorder/wiki/MinimalInstall ), and as a result trunk-recorder will not compile unless I apply the patch.