robotastic / trunk-recorder

Records calls from a Trunked Radio System (P25 & SmartNet)
GNU General Public License v3.0
850 stars 191 forks source link

Branch multi-system is not decoding smartnet control channel #67

Closed dreinhold closed 7 years ago

dreinhold commented 8 years ago

I just cant get the multi-system branch to decode my smart-net control channel.

First issue it was segfaulting, @trunk-recorder/systems/smartnet_parser.cc line 59: int command = atoi( x[2].c_str() ); The x vector did not always contain more that one array element.

I went back where he message is built and found in main.cc trunk_messages = smartnet_parser->parse_message(msg->to_string().erase(0, 10)); Which was this in master trunk_messages = smartnet_parser->parse_message(msg->to_string()); If I dropped the erase the segfaults went away, but I was still only decoding like 4 messages p/ sec.

Using the same config, just the new system layout.

robotastic commented 8 years ago

Sorry about that, I caught the .erase() bug it the slight later gr-latency branch. That is the branch I will probably merge in.

That is weird that it is getting that low decode rate. I did change the type of xlating filter that is used. Try switching out the FFT filter for the FIR filter. in trunk-recorder/systems/smartnet-trunking.cc, comment out lines 40-44 and try lines 45-48. You will also have to make the switch in smartnet-trunking.h

Let me know if that helps... That is pretty weird. Didn't seem to impact P25.

dreinhold commented 8 years ago

Yes after going back to FIR filter it's able to decode the control channel at full ~43 messages p/second.

robotastic commented 8 years ago

Interesting! Are the voice channels digital or analog? Are they coming through ok?

Sent from my iPhone

On Aug 16, 2016, at 10:13 PM, Dylan Reinhold notifications@github.com wrote:

Yes after going back to FIR filter it's able to decode the control channel at full ~43 messages p/second.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

dreinhold commented 8 years ago

The ones I listen to are analog so did not check that, but plenty of digital traffic. I'll check that later tonight. This is just on my test box, so i did not run it that long last night.

dreinhold commented 8 years ago

I was not able to decode digital channels, but I was also having trouble getting digital to decode when I went back to master. So i'm not sure it's the new code yet. I will try again in the next couple days,

robotastic commented 8 years ago

Hmm - I wonder if it could be the switch from DSD to OP25 to decode the audio. Maybe I will try to dig out a really old branch.

Sent from my iPhone

On Aug 20, 2016, at 10:30 AM, Dylan Reinhold notifications@github.com wrote:

I was not able to decode digital channels, but I was also having trouble getting digital to decode when I went back to master. So i'm not sure it's the new code yet. I will try again in the next couple days,

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

dreinhold commented 8 years ago

Master is working for digital after you went to op25. It was just not working on my test system when I reverted back. I think it's the system not the code.

On Aug 20, 2016 1:53 PM, "Luke Berndt" notifications@github.com wrote:

Hmm - I wonder if it could be the switch from DSD to OP25 to decode the audio. Maybe I will try to dig out a really old branch.

Sent from my iPhone

On Aug 20, 2016, at 10:30 AM, Dylan Reinhold notifications@github.com wrote:

I was not able to decode digital channels, but I was also having trouble getting digital to decode when I went back to master. So i'm not sure it's the new code yet. I will try again in the next couple days,

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/robotastic/trunk-recorder/issues/67#issuecomment-241223110, or mute the thread https://github.com/notifications/unsubscribe-auth/ABKukKQsoL_9Zb4_HbZHjFvnRvbZg2Nnks5qh2k-gaJpZM4Jl6mQ .

dreinhold commented 7 years ago

Closing this one out. Seems like smartnet-fun is the branch moving forward. I have a new machine coming this week so I can have a test box ;) I'll try that branch out here on my local system and open any new issues on that branch.

robotastic commented 7 years ago

Great! I think I should have improved CPU usage for SmartNet. I am also working on cleaning up the versioning/branching for the repo and adding in Docker Releases

On Sun, Oct 16, 2016 at 9:55 PM, Dylan Reinhold notifications@github.com wrote:

Closed #67 https://github.com/robotastic/trunk-recorder/issues/67.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/robotastic/trunk-recorder/issues/67#event-825315227, or mute the thread https://github.com/notifications/unsubscribe-auth/AAG53L2MAUPoOp0SAylvj-FMPoS3UL7_ks5q0tWrgaJpZM4Jl6mQ .