search

robotastic / trunk-recorder

Records calls from a Trunked Radio System (P25 & SmartNet)
GNU General Public License v3.0
863 stars 192 forks source link

improve duplicate detection for p25p2 TDMA #866

Closed taclane closed 10 months ago

taclane commented 10 months ago

Multi-site duplicate detection currently requires both calls to have the same TDMA slot number, even across different systems or frequencies. Depending on the slot assignments from the system controllers, there is only a 50% chance to correctly identify duplicate calls across TDMA networks.

Removing the line below requiring the same TDMA status and slot essentially doubles the reliability of dupe detection on these systems.

if ((call->get_phase2_tdma() == message.phase2_tdma) && (call->get_tdma_slot() == message.tdma_slot)) {
taclane commented 10 months ago

Following up on this, removing this line from the original multisite implementation was discussed back in June.

It was not doing anything besides occasionally preventing duplicate detection on TDMA systems.

taclane commented 10 months ago

Streamlined the console log entry per Discord feedback.