search

robotastic / trunk-recorder

Records calls from a Trunked Radio System (P25 & SmartNet)
GNU General Public License v3.0
827 stars 191 forks source link

Parse Motorola Patch Group Grant service options #869

Closed ArrEssJay closed 7 months ago

ArrEssJay commented 7 months ago

Service options (encryption etc.) for Motorola Patch Group Grants were not being parsed. Added this. They are not present in the update version. The patch service options already commented out relate to the 'moto patch group add' message so I removed these lines completely.

Just taking another look at this code, we parse the Patch Group as being equivalent to a Talkgroup, when it's specifying that it should also be patched to the target talkgroups listed for that patch group. We could also get a call to a talkgroup with the same number that should not be patched, unlikely as this seems.

I do sometimes see some inconsistent behaviour with regards to patched call handling and the talkgroup that trunk recorder lists as 'the' talkgroup that it was on, and talkgroup mismatch errors between the trunking/recorder.

Hence it may be worth being more diligent in the way these are tracked.

robotastic commented 7 months ago

Thanks - that looks good, merging it in

I am confused though - this same code gets called for GRANTS and PATCHES?