robotastic / trunk-recorder

Records calls from a Trunked Radio System (P25 & SmartNet)
GNU General Public License v3.0
827 stars 191 forks source link

Talkgroup Loading: Description is required error #915

Closed DarthXoc closed 5 months ago

DarthXoc commented 5 months ago

Summary

When loading Talkgroup data, loading can fail if the Description field is a String, but that String is convertible to an Int.

Expected Results

Talkgroup data should load if the value in the Description column is a String.

Actual Results

When loading Talkgroup data that was downloaded directly from Radio Reference, if the 'Description' field is an Int value wrapped in quotations (ex: "47"), the load will fail, even though the value's type is actually String.

Repro

1) Download Talkgroup data for Frisco (Frisco, TX) from Radio Reference 2) Configure Trunk Recorder to load this TG data 3) Attempt to start Trunk Recorder 4) Observe the error below:

[2024-01-28 15:23:37.767709] (info)   Loading Talkgroups...
[2024-01-28 15:23:37.767715] (info)   Reading Talkgroup CSV File: /scanner/config/frisco-channel-list.csv
[2024-01-28 15:23:37.768013] (info)   Found Columns: Decimal, Hex, Alpha Tag, Mode, Description, Tag, Category
[2024-01-28 15:23:37.768191] (error)   Description is required for Row: 56

5) Review Row 56

robotastic commented 5 months ago

Thanks for the well documented bug report! fixed this in the rf/v5.0 branch.