search

robotastic / trunk-recorder

Records calls from a Trunked Radio System (P25 & SmartNet)
GNU General Public License v3.0
827 stars 191 forks source link

don't remove call when upload failed #939

Open rosecitytransit opened 3 months ago

taclane commented 3 months ago

I don't know if there's an easy way to accomplish this without creating a new archiveFailedUploads config option, but just leaving the files in place might cause other issues.

The concern that comes to mind is that the default tempDir attempts to use a RAM-based filesystem. An extended network outage is likely to break trunk-recorder, or degrade the whole system, if it isn't cleaning up after calls.

rosecitytransit commented 3 months ago

That is a good point. Certainly an ongoing network issue (could be a configuration issue or OpenMHz/Broacastify issue too) could fill things up and cause havoc. For those who don't really have any local storage there may not be a place to put files that are in limbo. But it just seems bad to immediately, permanently delete things that haven't been successfully processed.

FWIW, the call that I was after was a 4015-second long open mic transmission that I had heard on my personal scanner but OpenMHz rejected it for being too large. One idea to handle that issue would be to have the maxDuration parameter apply to trunked as well as to conventional calls.