search

robotcodedev / robotcode

RobotFramework support for Visual Studio Code
https://robotcode.io
Apache License 2.0
173 stars 14 forks source link

Update diagnostic for Robocop 4.0 release after disablers module was rewritten #144

Closed bhirsz closed 1 year ago

bhirsz commented 1 year ago

We're getting ready to release Robocop 4.0. However I remember you have custom code to handle Robocop scans - and this code will not work after the release. Disablers module was rewritten and now instead of parsing the file as text file it parses it as Robot Framework file (so the disablers are context aware ie. disabler defined in the FOR loop will be re-enabled after the loop).

I'm not aware of your project setup so I didn't add any tests, didn't run anything except precommits etc.

d-biehl commented 1 year ago

Thank you for the PR. It is merged. Is the RoboCop repository up to date? So already with new disabler? So that I can test it?

Unfortunately you have committed the PR with a Github unknown email address, so you are not in the repo as a contributor :-(

bhirsz commented 1 year ago

Our repository is up to date, we are ready to release and the code on master branch will be used to release.

Ah, I probably commited with my work email. It doesnt matter really :)

d-biehl commented 1 year ago

OK, then I will test it this weekend and will let you know the result.

d-biehl commented 1 year ago

Just tested it, it works! Happy Release!!!