search

robotdana / spellr

Spell check your source code
MIT License
34 stars 2 forks source link

Ignore tsx.snap / js.snap / etc. files #50

Closed stephenkoo closed 5 years ago

stephenkoo commented 5 years ago

Salutations, @robotdana big fan.

My company is using this wonderful gem of a gem in our codebase but I have encountered an issue where it's detecting words in snap files. Could you take a look, please?

Screen Shot 2019-10-07 at 11 52 02
robotdana commented 5 years ago

Hi Mr Koo

There were three issues here.

  1. the built in javascript wordlist (that includes aria attributes) wasn't being used for .tsx.snap files.
  2. the built in javascript wordlist wasn't being used at all.
  3. the .tsx.snap files are being checked at all.

I don't want to change number 3 as i'd like that to be up to each repo. i recommend you add '*.tsx.snap' to the excludes list in your .spellr.yml (before v0.4.0 this was called ignore:) if you want to exclude these files.

upgrade to 0.4.1 released just now for fixes to 1 & 2