robotdotnet / DotNetDash

An extensible SmartDashboard replacement from the RobotDotNet project.
Other
0 stars 1 forks source link

Add support for WPILib Camera Streams #5

Closed ThadHouse closed 7 years ago

ThadHouse commented 7 years ago

The new camera streams from WPILib support a lot more features that we should support. Some are there, but this is discussion for whats left. Moved from https://github.com/robotdotnet/DotNetDash/commit/74a5b890b94e501431b1fd4a7b9355260c496221#commitcomment-20334419

ThadHouse commented 7 years ago

@jkoritzinsky Do you have a RoboRIO and a USB camera? If so I just realized its actually fairly easy to set up the wpilib streaming system without actually needing the new image.

jkoritzinsky commented 7 years ago

I don't have a USB camera. I've been using an MJPEG stream I have access to and reading the code to get table names.

jkoritzinsky commented 7 years ago

Table Names have been fixed everywhere.

jkoritzinsky commented 7 years ago

@ThadHouse The streams are now in subgroups under their camera names. Can you take a look and let me know if there's anything I'm missing?

ThadHouse commented 7 years ago

streams

Yup steams work. Still can't get any video output however. I can break on the creation of the CameraView and that works correctly. However neither the USB stream, nor the MJPEG streams show anything on my computer.

ThadHouse commented 7 years ago

Also I don't know exactly what create the garbage in the URL, but the same thing shows up in SmartDashboard and OutlineViewer, and I can still copy that URL into chrome and it works, along with the view creation not throwing an exception, so it shouldn't be an issue.

jkoritzinsky commented 7 years ago

Can you try the newest master to see if you get the video showing?

ThadHouse commented 7 years ago

Yup. It displays now. That's cool. I got the new docs site up and running too, so we should be able to add a doc page for this as well fairly easily.