search

robotdotnet / WPILib

DotNet implementation of WPILib for FIRST Robotics Competition (FRC)
27 stars 8 forks source link

Use more idiomatic C# under the hood #115

Closed msoucy closed 7 years ago

msoucy commented 7 years ago

Also makes some small tweaks to the public interface to make things more convenient

ThadHouse commented 7 years ago

Other than those 2 requested changes, everything else is good. Get those 2 portions into separate PR's and I'll merge the rest of them.

msoucy commented 7 years ago

I've removed the "default to no command" commit... which apparently github review didn't appreciate. It's a separate branch, which will be made as a PR soon.

The SendableChooser changes bring it more in line with upstream WPILib - according to wpilibsuite/allwpilib@15e58acc761cf4bf02737f8e014e983d32a739ed it uses a hashmap currently

ThadHouse commented 7 years ago

Oh I had forgotten we had actually merged that change. I thought it was still open. My bad.

msoucy commented 7 years ago

Is there anything else that needs to be done for this?

ThadHouse commented 7 years ago

I'll merge this tonight when I get home. I won't do a release until next weekend. I'm trying to match up with the WPILib release schedule, and I think we are planning on a release this weekend.