Closed msoucy closed 7 years ago
Other than those 2 requested changes, everything else is good. Get those 2 portions into separate PR's and I'll merge the rest of them.
I've removed the "default to no command" commit... which apparently github review didn't appreciate. It's a separate branch, which will be made as a PR soon.
The SendableChooser changes bring it more in line with upstream WPILib - according to wpilibsuite/allwpilib@15e58acc761cf4bf02737f8e014e983d32a739ed it uses a hashmap currently
Oh I had forgotten we had actually merged that change. I thought it was still open. My bad.
Is there anything else that needs to be done for this?
I'll merge this tonight when I get home. I won't do a release until next weekend. I'm trying to match up with the WPILib release schedule, and I think we are planning on a release this weekend.
Also makes some small tweaks to the public interface to make things more convenient