robotdotnet / WPILib

DotNet implementation of WPILib for FIRST Robotics Competition (FRC)
27 stars 8 forks source link

Subsystem defaults to no default command #117

Closed msoucy closed 4 years ago

msoucy commented 7 years ago

The safest action is to do nothing. This doesn't alter the template, but now subsystems that don't use a default command don't need the boilerplate.

codecov-io commented 7 years ago

Codecov Report

Merging #117 into master will decrease coverage by -0.01%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master     #117      +/-   ##
==========================================
- Coverage   16.07%   16.07%   -0.01%     
==========================================
  Files         127      127              
  Lines        7876     7877       +1     
  Branches      971      971              
==========================================
  Hits         1266     1266              
  Misses       6518     6518              
- Partials       92       93       +1
Impacted Files Coverage Δ
WPILib/Commands/Subsystem.cs 37.7% <ø> (-0.63%) :x:
WPILib/Utility.cs 51.21% <ø> (ø) :white_check_mark:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 62ce5dc...0b23385. Read the comment docs.

ThadHouse commented 7 years ago

I'm going to leave this one open until we can get an equivalent change merged into upstream WPILib. I want to keep the WPILib package that same as upstream.

ThadHouse commented 4 years ago

This is very much OBE by 2021 being a restart from the very beginning. We will be matching what is upstream.