search

robotdotnet / WPILib

DotNet implementation of WPILib for FIRST Robotics Competition (FRC)
27 stars 8 forks source link

Ordered Chooser #118

Open msoucy opened 7 years ago

msoucy commented 7 years ago

For feature parity with wpilibsuite/allwpilib#492, the chooser should be ordered.

See wpilibsuite/allwpilib#491 for rationale

ThadHouse commented 7 years ago

This is going to be a much harder fix in C#, since we don't have an equivalent in the .NET framework. I don't think C++ does either. In addition, I think we were actually looking at reworking sendable choosers for 2018, so we'll see. Most likely that PR won't get merged this season anyway.

msoucy commented 7 years ago

Slight nitpick - .NET does have an OrderedDictionary, though it does seem outdated. Does this planned rework remove the disparity with the Java WPILib, where sendables in .NET aren't templated?

ThadHouse commented 7 years ago

Yeah that ordered dictionary isn't even generic. So definitely no to that. They never created a generic one. TBH I had totally forgotten we made them generic in Java. That's not directly the reason for the rewrite however. We were looking at it to update some bugs that would be hard to remove from the current implementation. This hasn't been decided yet however.