search

robotframework / JavalibCore

Base for implementing Java test libraries to be used with Robot Framework
Other
42 stars 25 forks source link

Added @Autowired annotation, #8 #10

Closed MarkusBernhardt closed 11 years ago

MarkusBernhardt commented 11 years ago

First version, #8

ombre42 commented 11 years ago

Wow, that's cool that you provided an implementation! I think it would be a lot simpler to do the injection inside AnnotationLibraryFactory or AnnotationLibrary instead of the extractor. As implemented in the extractor, you had to change interfaces and constructors. That's just my two cents. I'm not a collaborator or anything.

MarkusBernhardt commented 11 years ago

You are so right about moving the code to the AnnotationLibrary itself will simplify the code a lot. In the beginning it felt natural to do it in the extractor, because the keyword annptations are handled there.

I'll change that.