robotframework / JavalibCore

Base for implementing Java test libraries to be used with Robot Framework

Other

42 stars 25 forks source link

Added Autowire annotation, #8 #11

Closed MarkusBernhardt closed 10 years ago

MarkusBernhardt commented 11 years ago

8

jussimalinen commented 10 years ago

Hi! Sorry for the delay, I am on a two week workshop, with a rather busy schedule including the evenings.. :P

This pull request looks really nice :) One problem though: the tests are still missing? Could you create a test that checks that the field values are auto wired?

I can also continue from here with the tests, but it might take a while before I have time to do that.

MarkusBernhardt commented 10 years ago

Hi Jussi,

I added a unit test now. I also noticed the AnnotationLibrary is lazy loading the keywords. Therefore the variables are not autowired before an implicit call of createKeywordFactory.

Cheers, Markus

jussimalinen commented 10 years ago

Looks good! Thanks. I will try this with some of our own libraries. If all goes well, I even might have next week time for a new release.

MarkusBernhardt commented 10 years ago

That would be really good, because I have already converted the Selenium2Library and begun a new SauceLabsLibrary based on that Annotation.