robotframework / RIDE

Test data editor for Robot Framework
Apache License 2.0
954 stars 376 forks source link

"search keywords" should be implemented as a notebook tab #228

Closed robotframework-ride closed 9 years ago

robotframework-ride commented 9 years ago

Originally submitted to Google Code by bryan.oakley on 7 Jul 2009

I think the "search keywords" feature should be re-implemented as notebook tab rather than as a floating window. The best way to do this would probably be to make this feature a plugin.

robotframework-ride commented 9 years ago

Originally submitted to Google Code by @yanne on 7 Jul 2009

Well, the only reason to keep the non-modal dialog is to be able to have both the editor and search result visible at the same time. I don't know which is better, because making this a plugin would be more consistent.

robotframework-ride commented 9 years ago

Originally submitted to Google Code by bryan.oakley on 7 Jul 2009

I guess a compromise would be to add a user preference which could be either "floating window" or "notebook tab". That would probably be pretty easy to do.

robotframework-ride commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 7 Jul 2009

I don't like too much configuration. We should be able to decide ourselves is non-modal dialog or notebook better. Since you can easily switch between tabs the notebook approach has pretty much the same benefits as dialog so it might be a good choice.

A related idea is making it possible to detach all notebooks so that they would form individual non-modal dialogs. It should, obviously, be possible to attach them back to the main UI somehow too. Gimp has panels like this and they work pretty well.

robotframework-ride commented 9 years ago

Originally submitted to Google Code by @yanne on 9 Jul 2009

Let's try to implement search as a plugin and see how it feels.

robotframework-ride commented 9 years ago

Originally submitted to Google Code by @yanne on 29 Sep 2009

This can be investigated further if decide to implement issue 225 .

robotframework-ride commented 9 years ago

Originally submitted to Google Code by @pekkaklarck on 6 Sep 2010

We discussed this with the core development team and agreed that we like the non-modal dialog approach better than the notebook tab. Having both options would be fine, either via config option or implementing detachable tabs, but these are so low priority that we won't do anything for them in a foreseeable future.

I close this issue now. It can be reopened if someone is interested to implement the additional support for notebook tabs.