robotframework / SeleniumLibrary

Web testing library for Robot Framework
Apache License 2.0
1.36k stars 751 forks source link

New attribute property keywords 1822 #1850

Closed emanlove closed 6 months ago

emanlove commented 11 months ago

Added Get DOM Attribute and Get Property keywords and several acceptance tests. I know these test can be cleaned up a bit. One bit of review I am looking for is whether all the tests are there? Or if there might be something missing? I also added some comments within the tests. One issue I have been coming across is that when I go into an internal test (either acceptance or unit) some of them I have a tough time trying to see exactly what is is testing, and what should I expect it to do and verify. So I started to play around a bit with comments. I don't think there that great and need improvement. But this starts to highlight one idea for explaining tests better.