robotframework / SeleniumLibrary

Web testing library for Robot Framework
Apache License 2.0
1.38k stars 759 forks source link

Copy any received files (and corresponding approved files) to results folder #1883

Open emanlove opened 8 months ago

emanlove commented 8 months ago

Occasionally there are errors within the approvaltests unit tests. These unit tests do post processing against know reults. When an eror occurs then the syst outputs the received files along side the files showing what was expected or the approved files. Like these

approved_file = '/home/runner/work/SeleniumLibrary/SeleniumLibrary/utest/test/keywords/approved_files/test_selenium_options_parser.test_split_options.approved.txt' received_file = '/home/runner/work/SeleniumLibrary/SeleniumLibrary/utest/test/keywords/approved_files/test_selenium_options_parser.test_split_options.received.txt'

Notice that the file directory for these is not under the atest/results folder which our GitHub Action workflow will zip and archive. I am wondering if it is worth saving these files as part of that archive? (Actually is there is an unit test failure within GitHub actions we might also have the issue that there is no results folder because we never run the atests. might be a secondary problem to looks at as well.)

Recording here as a reminder to look into this ..