search

robotframework / statuschecker

Tool for validating that executed Robot Framework test cases have expected statuses and log messages.
26 stars 9 forks source link

Python3 Compatibility: added parentheses to prints #1

Closed stasiek closed 8 years ago

stasiek commented 8 years ago

Tests return same results for Python 2 and 3.

pekkaklarck commented 8 years ago

Python 3 compatibility is a great idea. I submitted separate issue #2 about it with some additional tasks related to it. Do you @stasiek have time to take care of also them? Do you have any other enhancements in mind or should we create 1.3 release once Python 3 support is done?

Regarding to this PR, it's great to see that needed changes are minimal. I'd add from __future__ import print_function to affected files, though. Using print('foo') in Python 2 without it works in simple cases, but I don't think that's a good approach except for one-liners and very simple scripts.

stasiek commented 8 years ago

@pekkaklarck got no time to think about what else to change. For now I just need it for SSHLibrary Python 3 compatibility. Changes required in #2 included, I've also updated the copyright note.

stasiek commented 8 years ago

Forgot about importing future.print_function. I'll add it later today.

pekkaklarck commented 8 years ago

Cool, let's just create 1.3 with Python 3 compatibility then. Can you add print_function import and mention version that added Python 3 support in README (see my line note)? I can then create the release.

stasiek commented 8 years ago

Should be ready to merge now.

pekkaklarck commented 8 years ago

Two issue related to future imports:

Do you @stasiek have time to fix these today or should I do it myself? If you can fix them ASAP, I ought to still have time for creating a release. I have some other task that I need to do first, though.