robotics-in-concert / rocon_app_platform

Robotics in concert app framework
8 stars 18 forks source link

Smarter concert checking when getting invited #238

Closed stonier closed 9 years ago

stonier commented 10 years ago

Currently it checks the concert name against its current remote controller when getting an invite. If these are different, then it rejects the invite.

Problem: if the concert went down and for some reason the client was out of range (e.g. out of wireless), then it will reject the invite from a newly started concert because the postfixed uuid's will be different.

Solution: before immediately rejecting, make a quick check to see if the port connection is the same. If it is, be aware that it is a new concert, stop any rapps, delete the current remote controller and accept the invitation.

Note : no idea how we check the ip/port from the app manager. This would be the hub's port/ip and the gateway doesn't expose this information right now.

stonier commented 10 years ago

This problem was raised in https://github.com/robotics-in-concert/rocon_concert/issues/230

stonier commented 9 years ago

Dropping this as we won't implement in indigo.