search

robotics-in-concert / rocon_cento

1 stars 5 forks source link

Ideation post stream #15

Closed eskim closed 10 years ago

eskim commented 10 years ago

Implemented some features for Ideation perspective.

And this pull request is my first try for the next dev process.

adamantivm commented 10 years ago

Thank you very much for sending in the form of a pull request. This allows me to keep up to date with the work you're doing.

I'm also going to add some comments to the code, but please take them only as suggestions

adamantivm commented 10 years ago

Very nice! I'm merging and will take a look at it there.

eskim commented 10 years ago

@adamantivm Thanks for correcting me. Currently working on Coffeescript and Javascript at the same time makes me some minor mistakes.

I will follow the style guideline (e.g., https://github.com/airbnb/javascript/blob/master/README.md) as much as I can.

eskim commented 10 years ago

Ok, I found the tool we can check Javascript source code, called JSHint.

This(d06a572108e50823c73b4224759be7cc276b5fcd) is the sample fix with JSHint. This (https://gist.github.com/eskim/10078620) slightly modified JSHint config from AirBNB style guide was used.

If you like the style, I'll commit in to master branch and share it with all.

jihoonl commented 10 years ago

Sorry for sneak-in here :) I just wanted to say that I really like the AirBnB's Styling guideline and lint setup. It seems to make the code clean and easy to read.

Just for reference, there is ROS Javascript style guideline and and roslibjs JSHint configuration which has been used in all modules in RobotWebTools

The both ROS and AirBnB style guideline seem similar but Airbnb's with many more details. How would you guys think about merging these two guidelines and setup one sharable jshint configuration to follow the same style?

eskim commented 10 years ago

I sent pull request #16.