search

robotics-in-concert / rocon_multimaster

Key components for ros multimaster systems
12 stars 19 forks source link

invalid ROS names #336

Closed asmodehn closed 7 years ago

asmodehn commented 8 years ago

Need to be careful : as per specification ROS name format != hostname format.

Currently rocon uses hostname as robot name, but this should be properly formatted before. We should probably have warning in multiple places to check for validity of ros names...

The effect of using an invalid ROS name are still not clear. A warning message will be displayed by ROS : 

UserWarning: '/concert/clients/alexv-robotsim/battery' is not a legal ROS graph resource name. This may cause problems with other ROS tools
  super(Subscriber, self).__init__(name, data_class, Registration.SUB)
asmodehn commented 8 years ago

Note : I was able to flip topics that contained a dash '-', so this warning should not prevent from flipping topics.

stonier commented 8 years ago

Dashed topic will ultimately be unusable, regardless

On 21 Mar 2016 15:01, "AlexV" notifications@github.com wrote:

Note : I was able to flip topics that contained a dash '-', so this warning should not prevent from flipping topics.

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub

stonier commented 7 years ago

Closing this, the ros warning message is enough.