search

roboticslab-uc3m / jr3pci-linux

Imported from https://sourceforge.net/projects/jr3pci-linux/
https://sourceforge.net/projects/jr3pci-linux/
GNU Lesser General Public License v3.0
1 stars 3 forks source link

Look at struct-int-to-double branch #12

Open jgvictores opened 6 years ago

jgvictores commented 6 years ago

https://github.com/roboticslab-uc3m/yarp-devices/commit/184264ffc5b7b79b6ff26c8686a112f833e071c7

PeterBowman commented 5 years ago

https://github.com/roboticslab-uc3m/yarp-devices/issues/203#issuecomment-494062739:

Kinda unrelated, but I noticed that Clang complains about these lines:

https://github.com/roboticslab-uc3m/yarp-devices/blob/a538b382ddec2649c7c1f1ea9400be867ac49170/libraries/YarpPlugins/Jr3/DeviceDriverImpl.cpp#L24-L26

Each 5.5 value is narrowed down to 5 in order to fit into an integer-type variable.

jgvictores commented 5 years ago

On a side note, we never mention it, but the device is tightly related to https://github.com/roboticslab-uc3m/jr3pci-linux

jgvictores commented 5 years ago

On a side note, we never mention it, but the device is tightly related to https://github.com/roboticslab-uc3m/jr3pci-linux

Ref at https://github.com/roboticslab-uc3m/yarp-devices/commit/380480966fd16bed8c279c6fc32d241799bf9f08

PeterBowman commented 1 year ago

Since https://github.com/roboticslab-uc3m/yarp-devices/commit/02665e15ee1d429c6df87f021b5eb207d454db47 we no longer have two copies of the jr3pci-ioctl.h file, therefore I am going to delete the also duplicate branch in the yarp-devices repo.

New compare link: https://github.com/roboticslab-uc3m/jr3pci-linux/compare/master...struct-int-to-double.

New installation instructions: https://github.com/roboticslab-uc3m/installation-guides/commit/fd81c82385622567b07732b012691946a5b93fd8.