fixed python example - Githubissues

roboticslab-uc3m / kinematics-dynamics

Kinematics and dynamics solvers and controllers.

https://robots.uc3m.es/kinematics-dynamics/

GNU Lesser General Public License v2.1

19 stars 12 forks source link

fixed python example #149

Closed rsantos88 closed 6 years ago

rsantos88 commented 6 years ago

fixed python example

coveralls commented 6 years ago

Coverage remained the same at 53.746% when pulling f76275a94977a9b4228f9210564d0a6359e8e620 on issue#147 into e691990c372a07f68a7dc927696ead3c7bf0644e on develop.

PeterBowman commented 6 years ago

BTW this is a good chance to test the new wait command on Python :).

However, wait won't work on simulation because of this missing implementation in the YarpOpenraveControlboard device (called by the movj CMC handler). Pinging @jgvictores for awareness (not sure if this is covered by currently opened issues, would create one otherwise).

jgvictores commented 6 years ago

Note to self: bool OpenRAVE::ControllerBase::IsDone :-)

jgvictores commented 6 years ago

Ref: https://github.com/roboticslab-uc3m/openrave-yarp-plugins/issues/81

jgvictores commented 6 years ago

Implemented checkMotionDone as part of https://github.com/roboticslab-uc3m/openrave-yarp-plugins/issues/81. wait should work with current develop of https://github.com/roboticslab-uc3m/openrave-yarp-plugins (https://github.com/roboticslab-uc3m/openrave-yarp-plugins/commit/61c8d0198b1acf38e1246e9bf001e444c295d966).

PeterBowman commented 6 years ago

wait should work with current develop

Can confirm, wait command now behaves as expected on C++ example + simulator. Thanks!

rsantos88 commented 6 years ago

I've added wait function working perfectly and I took advantage to put the same movements as cpp example! It works cool :)

rsantos88 commented 6 years ago

changes applied. Thanks!

PeterBowman commented 6 years ago