search

roboticslab-uc3m / openrave-yarp-plugins

OpenRAVE plugins to interface OpenRAVE with YARP.
https://robots.uc3m.es/openrave-yarp-plugins/
GNU Lesser General Public License v2.1
3 stars 1 forks source link

YarpOpenraveBase bugs regarding `open` command #69

Open jgvictores opened 6 years ago

jgvictores commented 6 years ago

Discovered during #67, YarpOpenraveBase only send open with the --orPlugin parameter: https://github.com/roboticslab-uc3m/openrave-yarp-plugins/blob/2fe53a88fcd3dba4f5dbcc469ddf2e8a87bfb4c1/libraries/YarpPlugins/YarpOpenraveBase/YarpOpenraveBase.cpp#L114-L121

This may be intentional. The --orPlugins parameter is more powerful and apparently does pass more parameters. Check this.

jgvictores commented 6 years ago

Should also fix the fact that commands like these send strange commands (including dummyProgramName in name parameter): https://github.com/roboticslab-uc3m/openrave-yarp-plugins/blob/0d9b75806d5d927026b1e11017b13661c072b531/examples/openraveYarpPluginLoader-robotmanager.py#L16-L21

jgvictores commented 6 years ago

This in fact looks easy to fix; a simple clear before first push_back.

jgvictores commented 6 years ago

This in fact looks easy to fix; a simple clear before first push_back.

Better fix for the strange commands implemented and working at 68978df79f7d6dbdd767781faeae021b46f99c59.

jgvictores commented 6 years ago

Updated example at 6ece239dc058a04406a62f40834b54aae370ee51.

Leaving issue open to check initial statement (singular --orPlugin).