roboticslab-uc3m / openrave-yarp-plugins

OpenRAVE plugins to interface OpenRAVE with YARP.
https://robots.uc3m.es/openrave-yarp-plugins/
GNU Lesser General Public License v2.1
3 stars 1 forks source link

Remove local copy of asrob::IRobotManager #91

Closed PeterBowman closed 6 years ago

PeterBowman commented 6 years ago

We keep a local copy of said header in this repo at YarpOpenraveRobotManager/IRobotManager.hpp; the original file lives in asrob-uc3m/yarp-devices. We adopted this solution to avoid depending on another repository while all we need is a header, therefore copy-pasting seemed the way to keep things simple. However, users of the YarpOpenraveRobotManager device need to download and compile said repository anyway, since this plugin is wrapped by another YARP device hosted there. In other words: you can compile it if you want, but you won't be able to use it.

Proposal: make the YarpOpenraveRobotManager tree depend on ASROB_YARP_DEVICES, and disable it if this dependency is not found on system (per https://github.com/roboticslab-uc3m/questions-and-answers/issues/18). Remember to update .travis.yml accordingly.