search

roboticslab-uc3m / questions-and-answers

A place for general debate and question&answer
https://robots.uc3m.es/developer-manual/appendix/repository-index.html
2 stars 0 forks source link

Move or rename yarp plugins directories? #23

Closed jgvictores closed 6 years ago

jgvictores commented 7 years ago

As spoken with @David-Estevez the current names (TeoYarp, etc) are misleading. Options:

  1. Rename.
  2. Move contents up one level.

Opinions?

David-Estevez commented 7 years ago

Just to clarify, I was talking about the yarp-devices repo. In case there are differences between the code in this folder and the code in the same-level, I find correct to place all the sources for the plugins in a folder to distinguish them from the rest of the code. But, instead of naming this folder TeoYarp, as it is no longer related to Teo, I would call the folder 'yarp-devices' (or another descriptive name).

If all the plugins are similar, I think it is ok to put them on the same level.

jgvictores commented 7 years ago

Correct. Also clarifying, this happens among several repositories, that contain a YARP plugins folder which was not correctly renamed during the great transition. For instance:

PeterBowman commented 7 years ago

I'd pick a catchy name and use it consistently across all repos. Somebody took a step ahead a while ago and created a yarpplugins directory at openrave-yarp-plugins. On the other hand, YARP itself distinguishes between carriers and devices, placing them in their own folder: yarp/src/{carriers+devices}.

rsantos88 commented 6 years ago

https://github.com/roboticslab-uc3m/yarp-devices/tree/develop/libraries/BodyYarp -> (done it here) https://github.com/roboticslab-uc3m/kinematics-dynamics/tree/develop/libraries/TeoYarp -> (done it here) https://github.com/roboticslab-uc3m/vision/tree/develop/libraries/VisionYarp (done it here)

jgvictores commented 6 years ago
rsantos88 commented 6 years ago

https://github.com/roboticslab-uc3m/tools

done it here!!

rsantos88 commented 6 years ago

@jgvictores if you think that all of the changes are correct and there is nothing more to change, please close this issue :)

jgvictores commented 6 years ago

Yes, I also did this on openrave-yarp-plugins, so I think we're good to go.

@rsantos88 Thanks!

jgvictores commented 6 years ago

On the other hand, YARP itself distinguishes between carriers and devices, placing them in their own folder: yarp/src/{carriers+devices}.

Regarding this, I think we're okay to go for now, no existing carriers, no short-term plans, no long-term plans of creating many.