Closed jgvictores closed 5 years ago
We could have avoided https://github.com/roboticslab-uc3m/tools/issues/10#issuecomment-357375402 if examples were covered by tests.
Also, keep this in mind: roboticslab-uc3m/best-practices#21. Which boils down to: place Travis instructions that relate to building the examples in the before_script
YAML section.
Added TODO list to description.
CMake alias targets may be useful here.
Several examples are not even written in C/C++. Perhaps we could test bindings, too.
Idea: add_subdirectory(examples)
from root CMakeLists.txt, set ENABLE_examples=ON
in Travis (defaults to OFF)?
IMHO:
examples
at least compiled via Travis.examples
. If we add_subdirectory(examples)
, wouldn't it be catching repo-level dependencies rather than forcing them to be cited explicitly?As a solution, maybe forcing Travis to enter examples
and compile separately?
ASWJ:
if
clause, for instance these find_package() instructions
. Since we aim to illustrate best practices and usage of our libraries/APIs (targeted at devs), such hacks would be certainly misleading.before_script
section of .travis.yml.@PeterBowman Thanks!!!
Many repos have examples that are compiled separately... that should not mean not having them tested via Travis!