roboticslab-uc3m / questions-and-answers

A place for general debate and question&answer
https://robots.uc3m.es/developer-manual/appendix/repository-index.html
2 stars 0 forks source link

Compile examples in Travis builds #42

Closed jgvictores closed 5 years ago

jgvictores commented 6 years ago

Many repos have examples that are compiled separately... that should not mean not having them tested via Travis!


PeterBowman commented 6 years ago

We could have avoided https://github.com/roboticslab-uc3m/tools/issues/10#issuecomment-357375402 if examples were covered by tests.

Also, keep this in mind: roboticslab-uc3m/best-practices#21. Which boils down to: place Travis instructions that relate to building the examples in the before_script YAML section.

PeterBowman commented 6 years ago

Added TODO list to description.

PeterBowman commented 6 years ago

CMake alias targets may be useful here.

PeterBowman commented 6 years ago

Several examples are not even written in C/C++. Perhaps we could test bindings, too.

PeterBowman commented 5 years ago

Idea: add_subdirectory(examples) from root CMakeLists.txt, set ENABLE_examples=ON in Travis (defaults to OFF)?

jgvictores commented 5 years ago

IMHO:

  1. CI is great, and it would be great to have examples at least compiled via Travis.
  2. I'm happy with self-contained examples. If we add_subdirectory(examples), wouldn't it be catching repo-level dependencies rather than forcing them to be cited explicitly?

As a solution, maybe forcing Travis to enter examples and compile separately?

PeterBowman commented 5 years ago

ASWJ:

jgvictores commented 5 years ago

@PeterBowman Thanks!!!