search

roboticslab-uc3m / questions-and-answers

A place for general debate and question&answer
https://robots.uc3m.es/developer-manual/appendix/repository-index.html
2 stars 0 forks source link

Delete local clone/build trees of cached dependencies #70

Closed PeterBowman closed 6 years ago

PeterBowman commented 6 years ago

We test YARP releases extensively to make sure our downstream projects compile, thanks to: Travis cron jobs (https://github.com/roboticslab-uc3m/questions-and-answers/issues/17), cached builds (https://github.com/roboticslab-uc3m/questions-and-answers/issues/48) and YARP multi-release jobs (https://github.com/roboticslab-uc3m/questions-and-answers/issues/65). Sadly, a bug was discovered today a few hours before YARP v3.1.0 was released that renders the v3.0.x release cycle useless: https://github.com/robotology/QA/issues/313#issuecomment-409184722. It didn't hit our YARP master jobs because the local path I mentioned there actually existed as a result of the git clone we perform to get the latest commit. Also, it was a matter of luck that v3.0.1 was released one week before the final merge of the devel tree, and that a cron job reported the failure on our side "on time" (because of https://github.com/roboticslab-uc3m/openrave-yarp-plugins/commit/3f75fd6e3d9b3adf025ca52f19b4ad310e206332).

I propose here a more aggressive caching approach: let's delete the local clone/build tree as soon as it's possible, for all dependencies.

Regarding the YARP v3.0.1 cache entry, either pick a previous commit in v3.0.0 (if possible), or skip that release entirely.

PeterBowman commented 6 years ago

either pick a previous commit in v3.0.0 (if possible)

This would be https://github.com/robotology/yarp/commit/0cc300b674396503175b27167617364b07a58135. However, it's 135 commits behind v3.0.1 (with changes in over 1000 files): https://github.com/robotology/yarp/compare/0cc300b674396503175b27167617364b07a58135...v3.0.1.

PeterBowman commented 6 years ago

I propose here a more aggressive caching approach: let's delete the local clone/build tree as soon as it's possible, for all dependencies.

Done.

Regarding the YARP v3.0.1 cache entry, either pick a previous commit in v3.0.0 (if possible), or skip that release entirely.

Skipping in all repos.

PeterBowman commented 6 years ago

We can use https://github.com/robotology/yarp/commit/30dce540494b8cda5d9d40018384c047a8b47fe6 as a hotfix for the v3.0.x tree. Also, a new branch yarp-3.0 points at it.

PeterBowman commented 6 years ago

Done, I've reenabled YARP v3.0.1 via the hotfixed commit.