search

roboticslab-uc3m / teo-follow-me

Demo: A robotic face following and arm waving application.
1 stars 1 forks source link

followMeDialogueManager could benefit from some refactoring #43

Closed jgvictores closed 6 years ago

jgvictores commented 6 years ago

Certain parts and/or port/bottle naming can be improved, for instance: https://github.com/roboticslab-uc3m/follow-me/blob/b462dad42fc243732744ccb276249a341ce9c2d3/programs/followMeDialogueManager/FollowMeDialogueManager.cpp#L56-L96

As general practice:

rsantos88 commented 6 years ago

Sorry for doing this modification directly in develop branch Only I've modified the bottle names and the order of clear() function Commit: https://github.com/roboticslab-uc3m/follow-me/commit/35aae0e507b1d493222b22c9abd6fcec0120d55f

jgvictores commented 6 years ago

35aae0e507b1d493222b22c9abd6fcec0120d55f is good, thanks!

Closing issue.